7242 error when displaying message threads with a large number of participants #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue where message threads with a large number of participants were causing errors in the email thread display. The changes focus on improving the handling of email thread participants and ensuring the 'from' sender is always available.
Key changes include:
- Added a new
EmailThreadMessageWithSendertype inEmailThreadMessageWithSender.tsto ensure each message has an associated sender - Modified
useRightDrawerEmailThread.tsto fetch message senders separately and filter out messages without senders - Updated
RightDrawerEmailThread.tsxto simplify message rendering logic and add asenderprop toEmailThreadMessagecomponents - Adjusted
EmailThreadMessageParticipant.tsto include additional fields for better identification and typing - Updated
fetchAllThreadMessagesOperationSignatureFactory.tsto simplify themessageParticipantsfield in the GraphQL query
These changes should resolve the crash that occurred when the 'from' recipient couldn't be found in the list of participants, improving the stability of the email thread display feature.
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+158
to
+160
| if (!sender) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
style: Log missing senders for debugging purposes
packages/twenty-front/src/modules/activities/emails/types/EmailThreadMessageParticipant.ts
Show resolved
Hide resolved
charlesBochet
approved these changes
Sep 25, 2024
bosiraphael
deleted the
7242-error-when-displaying-message-threads-with-a-large-number-of-participants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7242