Fix LinkedIn URL special character formatting #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the formatting of LinkedIn URLs containing special characters, improving the display of profile identifiers.
- Modified
packages/twenty-front/src/utils/getDisplayValueByUrlType.tsto usedecodeURIComponent()for LinkedIn URLs - Enhances readability of LinkedIn profile names and company identifiers with encoded characters
- Affects components using
getDisplayValueByUrlType(), such as LinkDisplay, URLDisplay, and SocialLink - Improves user experience by showing more accurate LinkedIn URL representations
- Visual improvement demonstrated in before/after screenshots in the pull request description
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ehconitin
reviewed
Sep 25, 2024
| @@ -16,7 +16,7 @@ export const getDisplayValueByUrlType = ({ | |||
| /(?:https?:\/\/)?(?:www.)?linkedin.com\/(?:in|company|school)\/(.*)/, | |||
| ); | |||
| if (isDefined(matches?.[1])) { | |||
| return matches?.[1]; | |||
| return decodeURIComponent(matches?.[1]); | |||
bosiraphael
approved these changes
Sep 25, 2024
|
Thanks @ad-elias for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
