feat(sso): allow to use OIDC and SAML #7246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoreaux
changed the title
AMoreaux
changed the title
packages/twenty-server/src/engine/core-modules/sso/services/sso.service.ts
Outdated
Show resolved
Hide resolved
AMoreaux
force-pushed
the
feat/sso
branch
4 times, most recently
from
b36df35
to
1002d06
Compare
AMoreaux
commented
Oct 3, 2024
| return await createOidcIdentityProviderMutation({ | ||
| variables: { input }, | ||
| onCompleted: (data) => { | ||
| setSSOIdentitiesProviders((existingProvider) => [ |
There was a problem hiding this comment.
@charlesBochet do you have an idea why this call does not refresh the list of providers used in the component SettingsSSOIdentitiesProvidersListCard.tsx
There was a problem hiding this comment.
not sure, let's investigate together tomorrow
AMoreaux
force-pushed
the
feat/sso
branch
3 times, most recently
from
f20766c
to
abedc1e
Compare
AMoreaux
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces Single Sign-On (SSO) functionality to the application, supporting both OIDC and SAML protocols. The changes focus on implementing SSO management in the settings area.
- Added new
SettingsSSOIdentitiesProvidersFormcomponent for configuring SSO providers - Implemented GraphQL mutations and queries for CRUD operations on SSO providers
- Created utility functions for parsing SAML metadata and determining SSO provider icons
- Added new
IS_SSO_ENABLEDfeature flag to control SSO functionality across the app - Integrated SSO settings into existing navigation and routing components
30 file(s) reviewed, 22 comment(s)
Edit PR Review Bot Settings
...twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersForm.tsx
Outdated
Show resolved
Hide resolved
...twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersForm.tsx
Outdated
Show resolved
Hide resolved
...ty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCard.tsx
Outdated
Show resolved
Hide resolved
...ty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCard.tsx
Outdated
Show resolved
Hide resolved
...rc/modules/settings/security/components/SettingsSSOIdentitiesProvidersListEmptyStateCard.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/security/utils/SSOIdentityProviderSchema.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/security/utils/gessIconByUrl.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/security/utils/parseXMLMetadata.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/security/utils/parseXMLMetadata.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/SettingsWorkspaceMembers.tsx
Outdated
Show resolved
Hide resolved
AMoreaux
force-pushed
the
feat/sso
branch
3 times, most recently
from
1160909
to
18d2420
Compare
|
@AMoreaux could you merge main into your branch and make sure the CIs are green? :) |
charlesBochet
added
-PR: awaiting review
and removed
-PR: wip
-PR: awaiting author
labels
| @@ -77,6 +77,7 @@ const StyledButton = styled.button< | |||
| justify-content: center; | |||
| outline: none; | |||
| padding: ${({ theme }) => theme.spacing(2)} ${({ theme }) => theme.spacing(3)}; | |||
| max-height: ${({ theme }) => theme.spacing(8)}; | |||
There was a problem hiding this comment.
not sure this one is useful!
charlesBochet
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Backend
Frontend