feat: view groups #7176

magrinj · 2024-09-20T10:07:08Z

This pull request introduces the new "view groups" capability, enabling the reordering, hiding, and showing of columns in Kanban mode. The core enhancement includes the addition of a new entity named ViewGroup, which manages column behaviors and interactions.

Key Changes:

ViewGroup Entity:
The newly added ViewGroup entity is responsible for handling the organization and state of columns.
This includes:
- The ability to reorder columns.
- The option to hide or show specific columns based on user preferences.

Conclusion:

This PR adds a significant new feature that enhances the flexibility of Kanban views through the ViewGroup entity.
We'll later add the view group logic to table view too.

github-actions · 2024-09-26T14:39:43Z

TODOs/FIXMEs:

~~// TODO: we should make sure there's no way to have a mismatch between columnIds and possibleKanbanSelectFieldValues order~~: packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexBoardDataLoader.tsx
// FixMe: Why do we have 2 useEffects for setFieldDefinitions?: packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexBoardDataLoaderEffect.tsx

Generated by 🚫 dangerJS against 7615d50

charlesBochet · 2024-10-05T10:11:13Z

I will close this one as it's not ready yet, let's re-open it next week!

packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsx

magrinj · 2024-10-15T14:38:56Z

packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsx

+  // FixMe: Check if we really need this as it depends on the times it takes to update the view groups
+  // if (isPersistingViewGroups) {
+  //   // TODO: Add skeleton state
+  //   return null;
+  // }


To determine during testing

greptile-apps

PR Summary

This pull request introduces the new 'ViewGroup' entity to enhance Kanban view functionality, allowing users to reorder, hide, and show columns. The changes implement a more flexible and customizable column management system.

Added ViewGroup to CoreObjectNameSingular enum in metadata types
Implemented useRecordGroupActions hook for 'Edit' and 'Hide' actions on columns
Created useRecordGroupReorder hook to handle drag-and-drop reordering of columns
Introduced RecordGroupDefinition type to replace RecordBoardColumnDefinition
Updated RecordIndexOptionsDropdownContent with new menu items for view group management
Removed isFirstColumnFamilyState and isLastColumnFamilyState, simplifying column management

_{30 file(s) reviewed, 28 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsx

greptile-apps · 2024-10-15T14:43:24Z

packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsx

+  // FixMe: Check if we really need this as it depends on the times it takes to update the view groups
+  // if (isPersistingViewGroups) {
+  //   // TODO: Add skeleton state
+  //   return null;
+  // }


style: Remove or implement the commented code for persisting view groups

packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsx

...enty-front/src/modules/object-record/record-board/hooks/internal/useSetRecordBoardColumns.ts

.../src/modules/object-record/record-board/record-board-column/components/RecordBoardColumn.tsx

...wenty-front/src/modules/object-record/record-index/components/RecordIndexBoardDataLoader.tsx

...front/src/modules/object-record/record-index/components/RecordIndexBoardDataLoaderEffect.tsx

greptile-apps · 2024-10-15T14:58:34Z

...front/src/modules/object-record/record-index/components/RecordIndexBoardDataLoaderEffect.tsx

+  // FixMe: Why do we have 2 useEffects for setFieldDefinitions?
  useEffect(() => {
    setFieldDefinitions(recordIndexFieldDefinitions);
  }, [objectMetadataItem, setFieldDefinitions, recordIndexFieldDefinitions]);


logic: Duplicate useEffect for setFieldDefinitions. Consider consolidating or removing one of these effects.

packages/twenty-front/src/modules/object-record/record-index/hooks/useLoadRecordIndexBoard.ts

packages/twenty-front/src/modules/object-record/record-group/hooks/useRecordGroupStates.ts

packages/twenty-front/src/modules/object-record/record-group/types/RecordGroupDefinition.ts

packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsx

.../modules/object-record/record-index/options/components/RecordIndexOptionsDropdownContent.tsx

packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemDraggable.tsx

packages/twenty-front/src/modules/views/hooks/internal/usePersistViewGroupRecords.ts

packages/twenty-front/src/modules/views/states/contexts/CurrentViewComponentInstanceContext.tsx

packages/twenty-front/src/modules/views/utils/mapGroupDefinitionsToViewGroups.ts

packages/twenty-front/src/modules/views/utils/mapViewGroupsToGroupDefinitions.ts

magrinj added 6 commits September 20, 2024 12:06

feat: wip view groups

b45b652

feat: wip create record group

5375890

feat: construct columns from view groups

1835bc1

Merge remote-tracking branch 'origin/main' into feat/view-groups

3776a83

feat: wip reorder

9230495

fix: finally align column records with column id

7379b41

magrinj added 2 commits September 27, 2024 12:33

fix: can hide board columns

d770255

fix

b9ea518

charlesBochet added the -PR: wip label Oct 5, 2024

charlesBochet assigned magrinj Oct 5, 2024

charlesBochet added the -PR: awaiting author label Oct 5, 2024

charlesBochet closed this Oct 5, 2024

Merge branch 'main' into feat/view-groups

d28675c

magrinj reopened this Oct 14, 2024

magrinj added 2 commits October 15, 2024 12:08

feat: view group actions

7d27a03

Merge branch 'main' into feat/view-groups

0fd7080

magrinj force-pushed the feat/view-groups branch from 717c834 to 866216d Compare October 15, 2024 10:38

fix: set menu to viewGroups when hidden groups are empty

b11be8d

magrinj force-pushed the feat/view-groups branch from 866216d to b11be8d Compare October 15, 2024 13:02

magrinj added 3 commits October 15, 2024 16:07

fix: use css for border instead of code logic

e00cf0e

Merge branch 'main' into feat/view-groups

b0609f6

fix: lint

defa000

magrinj commented Oct 15, 2024

View reviewed changes

magrinj marked this pull request as ready for review October 15, 2024 14:42

magrinj requested review from charlesBochet and lucasbordeau October 15, 2024 14:42

greptile-apps bot reviewed Oct 15, 2024

View reviewed changes

magrinj removed the -PR: wip label Oct 16, 2024

magrinj added the -PR: awaiting review label Oct 16, 2024

magrinj added 2 commits October 16, 2024 09:49

fix: small fixes

c06c6d7

Merge branch 'main' into feat/view-groups

7615d50

magrinj commented Oct 21, 2024

View reviewed changes

packages/twenty-front/src/modules/object-record/record-group/hooks/useRecordGroupStates.ts Outdated Show resolved Hide resolved

charlesBochet force-pushed the main branch from 1c484d5 to 2f72e22 Compare October 21, 2024 11:19

magrinj added 6 commits October 21, 2024 14:19

feat: scope recordGroupDefinitionState by viewId

ed723ca

Merge remote-tracking branch 'origin/main' into feat/view-groups

b0f5833

fix: drop again isFirstColumn and isLastColumn states

d3058d7

Merge remote-tracking branch 'origin/main' into feat/view-groups

ee13123

fix: merge issues

2d09ce8

fix: board borders

64b4232

lucasbordeau reviewed Oct 21, 2024

View reviewed changes

magrinj and others added 3 commits October 22, 2024 08:58

Merge branch 'main' into feat/view-groups

8264951

fix: make changes required by the review

a76ea95

Merge branch 'main' into feat/view-groups

46c58bd

lucasbordeau self-requested a review October 23, 2024 09:08

lucasbordeau added 10 commits October 23, 2024 11:42

Fix

7714331

Fix

3ce3314

Fix

9bc63d3

Fix creation

86d1488

Fix no value

04a3d07

Fix lint

2f59bab

Fix coverage

529d819

Fix msw log

5751bd9

Fix sb logs

c9604d3

Merge branch 'main' into feat/view-groups

7d72880

lucasbordeau approved these changes Oct 24, 2024

View reviewed changes

Fix CI

f7922df

FelixMalfait merged commit e8d96cf into main Oct 24, 2024
18 checks passed

FelixMalfait deleted the feat/view-groups branch October 24, 2024 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: view groups #7176

feat: view groups #7176

magrinj commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

charlesBochet commented Oct 5, 2024

magrinj Oct 15, 2024

greptile-apps bot left a comment

greptile-apps bot Oct 15, 2024

greptile-apps bot Oct 15, 2024

feat: view groups #7176

feat: view groups #7176

Conversation

magrinj commented Sep 20, 2024 • edited Loading

Key Changes:

Conclusion:

github-actions bot commented Sep 26, 2024 • edited Loading

TODOs/FIXMEs:

charlesBochet commented Oct 5, 2024

magrinj Oct 15, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Oct 15, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 15, 2024

Choose a reason for hiding this comment

magrinj commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading