7154 deleted event is not emitted when calling destroyone #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the issue of deleted events not being emitted when calling the destroyOne method. Here's a summary of the key changes:
- Implemented 'destroyed' event emission in GraphqlQueryRunnerService's destroyOne method
- Added ObjectRecordDestroyEvent class to represent object destruction events
- Updated multiple listeners to handle 'destroyed' events instead of 'deleted' events
- Modified ConnectedAccountDeleteOnePreQueryHook to work with 'destroyOne' operation
- Added support for 'destroy' operation in webhook jobs and query hooks
- Enhanced DatabaseEventTriggerListener to process 'destroyed' events for workflow triggers
These changes ensure consistent event handling across the application when objects are destroyed, addressing the core issue described in #7154.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
...es/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-runner.service.ts
Outdated
Show resolved
Hide resolved
.../messaging/message-cleaner/listeners/messaging-message-cleaner-connected-account.listener.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Sep 27, 2024
charlesBochet
deleted the
7154-deleted-event-is-not-emitted-when-calling-destroyone
branch
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7154