Clean views without object metadata #7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a new command to clean views with deleted object metadata and updates the upgrade process for version 0.31. The changes focus on maintaining data integrity and improving the object deletion process.
- Added
CleanViewsWithDeletedObjectMetadataCommandto identify and delete orphaned views during the 0.31 upgrade process - Modified
ObjectMetadataServiceto delete associated views when deleting an object, preventing orphaned data - Updated
UpgradeTo0_31Commandto include workspace metadata synchronization and view cleaning before backfilling workspace favorites - Removed
FeatureFlagModuledependency fromObjectMetadataModule, simplifying the module structure - Introduced dry run mode and detailed logging in the new cleaning command for better control and visibility during the upgrade process
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
...abase/commands/upgrade-version/0-31/0-31-clean-views-with-deleted-object-metadata.command.ts
Show resolved
Hide resolved
...abase/commands/upgrade-version/0-31/0-31-clean-views-with-deleted-object-metadata.command.ts
Show resolved
Hide resolved
...abase/commands/upgrade-version/0-31/0-31-clean-views-with-deleted-object-metadata.command.ts
Show resolved
Hide resolved
| }, | ||
| }); | ||
|
|
||
| if (views.length >= 0) { |
There was a problem hiding this comment.
logic: Condition should be views.length > 0 instead of >= 0
charlesBochet
approved these changes
Sep 19, 2024
| await this.cleanViewsWithDeletedObjectMetadataCommand.executeActiveWorkspacesCommand( | ||
| passedParam, | ||
| { | ||
| ...options, |
There was a problem hiding this comment.
{ ... options } ==> options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command for cleaning + clean on object deletion