Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6694 remove raw queries from connected account #7101

Merged
merged 10 commits into from
Oct 8, 2024

Conversation

bosiraphael
Copy link
Contributor

Closes #6694

@bosiraphael bosiraphael linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 17, 2024

TODOs/FIXMEs:

  • // TODO: modify handleAliases to be of fieldmetadatatype array: packages/twenty-server/src/modules/connected-account/email-alias-manager/services/email-alias-manager.service.ts

Generated by 🚫 dangerJS against 1a38412

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request removes raw queries from the connected account module and replaces them with TwentyORM across multiple files in the project.

  • Removed ConnectedAccountRepository and its dependencies from various modules and services
  • Updated GoogleAPIsService to use TwentyORM for database operations, improving transaction management
  • Modified EmailAliasManagerService to use TwentyORM, simplifying the refreshHandleAliases method
  • Refactored RefreshAccessTokenService to use TwentyORM for access token updates
  • Updated calendar and messaging modules to use TwentyORM for connected account queries

19 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings

@lucasbordeau
Copy link
Contributor

Farewell raw queries ...

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bosiraphael bosiraphael merged commit 33d5a57 into main Oct 8, 2024
8 checks passed
@bosiraphael bosiraphael deleted the 6694-remove-raw-queries-from-connected-account branch October 8, 2024 11:31
harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove raw queries from connected account
3 participants