-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6694 remove raw queries from connected account #7101
6694 remove raw queries from connected account #7101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request removes raw queries from the connected account module and replaces them with TwentyORM across multiple files in the project.
- Removed ConnectedAccountRepository and its dependencies from various modules and services
- Updated GoogleAPIsService to use TwentyORM for database operations, improving transaction management
- Modified EmailAliasManagerService to use TwentyORM, simplifying the refreshHandleAliases method
- Refactored RefreshAccessTokenService to use TwentyORM for access token updates
- Updated calendar and messaging modules to use TwentyORM for connected account queries
19 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings
...er/src/modules/connected-account/email-alias-manager/services/email-alias-manager.service.ts
Show resolved
Hide resolved
...ules/connected-account/refresh-access-token-manager/services/refresh-access-token.service.ts
Show resolved
Hide resolved
...ules/connected-account/refresh-access-token-manager/services/refresh-access-token.service.ts
Show resolved
Hide resolved
.../src/modules/messaging/message-import-manager/drivers/gmail/messaging-gmail-driver.module.ts
Show resolved
Hide resolved
...ty-server/src/modules/messaging/message-import-manager/jobs/messaging-messages-import.job.ts
Outdated
Show resolved
Hide resolved
Farewell raw queries ... |
packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-query-hook.module.ts
Show resolved
Hide resolved
...r/src/modules/calendar/calendar-event-import-manager/calendar-event-import-manager.module.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/object-metadata-repository/metadata-to-repository.mapping.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes twentyhq#6694 --------- Co-authored-by: Charles Bochet <[email protected]>
Closes #6694