Fix search on email #7094
Merged
Fix search on email #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses a critical issue with email search functionality following a migration from a single 'email' field to a composite 'emails' field.
- Updated
CommandMenu.tsxto use the new 'emails' field structure for people search - Implemented
generateILikeFiltersForCompositeFieldsfor 'emails.primaryEmail' in the search filter - Fixed GraphQL query error caused by the outdated 'email' field in the search functionality
- Resolved issue New users cannot search since missing email field #7080 where new users couldn't search due to the missing 'email' field
- Ensures compatibility with the recent database schema change for email storage
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following email (text field type) -> emails (emails field type - composite) migration!
closes #7080