Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search on email #7094

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix search on email #7094

merged 1 commit into from
Sep 17, 2024

Conversation

ijreilly
Copy link
Collaborator

following email (text field type) -> emails (emails field type - composite) migration!

closes #7080

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses a critical issue with email search functionality following a migration from a single 'email' field to a composite 'emails' field.

  • Updated CommandMenu.tsx to use the new 'emails' field structure for people search
  • Implemented generateILikeFiltersForCompositeFields for 'emails.primaryEmail' in the search filter
  • Fixed GraphQL query error caused by the outdated 'email' field in the search functionality
  • Resolved issue New users cannot search since missing email field #7080 where new users couldn't search due to the missing 'email' field
  • Ensures compatibility with the recent database schema change for email storage

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet merged commit fe4ca21 into main Sep 17, 2024
13 checks passed
@charlesBochet charlesBochet deleted the fix-search-email branch September 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New users cannot search since missing email field
2 participants