TWNTY-6808 - Ability to Filter by Creation Source

[gitstart-app]

Description

• Ability to Filter by Creation Source

Demo

LOOM: https://www.loom.com/share/dba9c3d37a4242fe90f977b1babffbde?sid=59b07c51-d245-43cc-bb38-7d898ef72878

Refs

#6808

Fixes #6808

[greptile-apps]

PR Summary

This pull request implements the ability to filter records by Creation Source, addressing issue #6808. Key changes include:

• Added 'SOURCE' filter type in FilterType.ts and related components
• Implemented sub-menu functionality for 'ACTOR' filter type in ObjectFilterDropdownFilterSelect.tsx
• Created new ObjectFilterDropdownSourceSelect.tsx component for source filtering
• Updated turnObjectDropdownFilterIntoQueryFilter.ts to handle 'SOURCE' subfield in ACTOR filters
• Modified FilterDefinition type to include optional 'subFieldType' for more granular filtering
• Added utility functions getSubMenuOptions.ts and hasSubMenuFilter.ts to support new filtering structure

_{15 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings}

[gitstart-twenty]

Thanks for the review @lucasbordeau , We are working on it

[gitstart-twenty]

We are working on resolving the conflicts

[gitstart-twenty]

thanks for the feedback @bosiraphael , we will work on it

[bosiraphael]

@gitstart-twenty thank you for the changes! Is it possible to add the possibility to add Icons to the items in the multiselect ? The UI will be much clearer.

What do you think about that @Bonapara?

[Bonapara]

Yes, we should add the icons! Regarding the font, it shouldn't be uppercase but capitalized.

[gitstart-twenty]

Hello @Bonapara
could you provide the correct icons that we should use?

[Bonapara]

Here are the icons:

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=1406-44830&node-type=frame&t=NvkpK4dfe3Mv1wrT-11

Just need to add user-circle for "Manual" that should be renamed into "User"

Can you also replace the user-circle icon used for Creator name by the ID icon?

[gitstart-twenty]

Hello @Bonapara In the link you sent, We could not identify which icons should be used for each creation source type in the link you sent.
could you help us define the icons?

Manual -> user-circle ✔️
Api ->
Import ->
Calendar ->
Email ->

[Bonapara]

Hello @Bonapara In the link you sent, We could not identify which icons should be used for each creation source type in the link you sent. could you help us define the icons?

Manual -> user-circle ✔️ Api -> Import -> Calendar -> Email ->

I meant these icons/illustrations:

[gitstart-twenty]

Oh, thank you @Bonapara. Just One more question, about this icon, which type is this? is it WORKFLOW?

[Bonapara]

Oh, thank you @Bonapara. Just One more question, about this icon, which type is this? is it WORKFLOW?

This is related to this issue -> #6924

[gitstart-twenty]

ok, thank you

[gitstart-twenty]

Hello @Bonapara, just another question
which icon should we use for the WORKFLOW source type?

[Bonapara]

Just added it to the Figma, thanks!

[bosiraphael]

LGTM

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-2bbdb879.json

Generated by 🚫 dangerJS against ce1f4d0