[Emails migration] Fix email field migration #7065
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issues with email field migration in the Twenty application, focusing on improving the robustness of the process and ensuring proper data handling.
- Introduces new
FixEmailFieldsToEmailsCommandto remove deprecated email fields and add the new 'emails' field to person views - Updates
UpgradeTo0_30Commandto include the new fix command in the upgrade process - Adds
getViewsIdsForObjectMetadataIdmethod toViewServicefor retrieving view IDs associated with specific object metadata - Implements error handling and logging throughout the migration process for better debugging and monitoring
- Ensures compatibility with the new email field structure across workspaces
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| workspaceQueryRunner = workspaceDataSource.createQueryRunner(); | ||
|
|
||
| await workspaceQueryRunner.connect(); |
There was a problem hiding this comment.
style: Consider wrapping the query runner in a try-finally block to ensure it's always released, even if an error occurs during connection.
| positions: personViewsIds.reduce((acc, personView) => { | ||
| if (!personView.id) { | ||
| return acc; | ||
| } | ||
| acc[personView.id] = 4; | ||
|
|
||
| return acc; | ||
| }, []), |
There was a problem hiding this comment.
logic: This reduce function initializes 'acc' as an array but uses it as an object. Consider initializing it as an object: personViewsIds.reduce((acc, personView) => { ... }, {})
| }); | ||
| this.logger.log(chalk.green(`Added emails to view ${workspaceId}.`)); | ||
| } catch (error) { | ||
| await workspaceQueryRunner.release(); |
There was a problem hiding this comment.
style: workspaceQueryRunner is released here and again in the finally block. Consider removing this line to avoid potential errors.
Fix email field migration