relations header button to appear at all times for mobile devices #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses the visibility of relation header buttons on mobile devices, improving user experience and discoverability of actions.
- Modified
RecordDetailRelationSection.tsxto useuseIsMobilehook for detecting mobile devices - Adjusted visibility of add/edit button to always show on mobile, not just on hover
- Removed
displayOnHoverclass for mobile devices inLightIconButtoncomponent - Improved accessibility for new users on mobile by making dropdown actions more apparent
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ehconitin
commented
Sep 16, 2024
| @@ -54,6 +55,7 @@ export const RecordDetailRelationSection = ({ | |||
| } = fieldDefinition.metadata as FieldRelationMetadata; | |||
| const record = useRecoilValue(recordStoreFamilyState(recordId)); | |||
|
|
|||
| const isMobile = useIsMobile(); | |||
There was a problem hiding this comment.
Or should I pass in the prop in either Context or to the component from RecordShowContainer?
bosiraphael
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Hello @ehconitin ! Thank you for contributing :) LGTM, left a comment
...s/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
Outdated
Show resolved
Hide resolved
|
Thanks @ehconitin for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7036