Fix for view switcher default icon display #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issue #6947 by modifying the IconPicker component and ViewPickerCreateOrEditContent to correctly display default icons for Table and Kanban views until a custom icon is selected.
- Added
takeControlOfCustomIconprop to IconPicker for distinguishing between default and custom icons - Implemented
getIconForIconPickerfunction in IconPicker to determine the correct icon to display - Introduced
takeControlOfCustomIconstate in ViewPickerCreateOrEditContent to track custom icon selection - Updated IconPicker usage in ViewPickerCreateOrEditContent to respect the default icon until explicitly changed
- Reset icon control when view type changes in ViewPickerCreateOrEditContent
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Thanks for the PR!
See my comments :)
- Let's not introduce a new props and behavior on IconPicker
- Let's set the default icon in ViewPickerCreateOrEditContentEffect instead for viewCreation case
- you are pushing a new yarn.lock which is incorrect could you remove this file from your commit?
packages/twenty-front/src/modules/ui/input/components/IconPicker.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/input/components/IconPicker.tsx
Outdated
Show resolved
Hide resolved
...ages/twenty-front/src/modules/views/view-picker/components/ViewPickerCreateOrEditContent.tsx
Outdated
Show resolved
Hide resolved
|
@rathodvinod5 The solution was to use a state in |
lucasbordeau
approved these changes
Oct 10, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fixes twentyhq#6947 (View switcher default icon display) --------- Co-authored-by: Lucas Bordeau <[email protected]>
|
@lucasbordeau thanks for the guide, I will follow this practice in my future PR's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6947 (View switcher default icon display)