-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: page header accessible when deleting webhook #6985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses accessibility issues with the PageHeader component, particularly for mobile viewports and when deleting webhooks.
- Modified
StyledTopBarContainer
inPageHeader.tsx
to adjust width and padding for mobile devices - Removed z-index property from
StyledTopBarContainer
, potentially affecting stacking order - Changes aim to keep header and buttons accessible during webhook deletion
- Modifications should improve visibility of save/cancel buttons on mobile devices
- Webhook-related files need review to ensure proper interaction with updated PageHeader component
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @harshit078, thank you for contributing !
I modified your PR to put back the z-index, this will be fixed in another PR: #6737 (comment)
Also, I changed the width of 93% to use 100% and changed the box-sizing to border-box.
There is still the issue that we are able to click on the buttons which are behind the overlay on mobile, this is likely due to a bug in useListenClickOutsideV2
. I'll let @lucasbordeau take a look.
Log
|
Description
This PR resolves the issue #6817
max-width
Current Behaviour
Screen.Recording.2024-09-11.at.4.25.47.PM.mov
Expected behavior
Screen.Recording.2024-08-31.at.7.09.35.PM.mov