Fixes stage filter not working in Kanban View ( #5496 ) #6896
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the issue of cards disappearing when moved to filtered stages in the Kanban view.
- Modified filter logic in
useLoadRecordIndexBoardColumnhook to prioritizerequestFiltersover column-specific filters - Ensures cards remain visible when moved to filtered stages in Kanban view
- Improves consistency of card visibility across different board columns
- Addresses core functionality issue in the Kanban board drag-and-drop feature
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| const filter = requestFilters | ||
| ? requestFilters | ||
| : { | ||
| [recordIndexKanbanFieldMetadataItem?.name ?? '']: isDefined( | ||
| columnFieldSelectValue, | ||
| ) | ||
| ? { in: [columnFieldSelectValue] } | ||
| : { is: 'NULL' }, | ||
| }; |
There was a problem hiding this comment.
logic: This change allows for more flexible filtering, but ensure it doesn't break existing functionality in other parts of the application that rely on the previous filter behavior.
There was a problem hiding this comment.
Thanks!
I'm surprised, it seems requestFilters already contains everything and we can actually use it directly.
Maybe @lucasbordeau you have more knowledge about this part?
Otherwise it seems to work
|
@Weiko I checked the gitblame and the context is this: 2cd624a So the above fix seems incorrect because it'd probably break the "No value" column results when we apply filter. I'm open to just hiding the kanban field from filters if it's easier and clean in the code. Both options are okay. |
|
Hey @Faisal-imtiyaz123 closing since it wasn't addressed after my previous comment. Thanks for the attempt! cc @magrinj I think when you refactor viewGroups/Kanban this might solve the above issue |
fixes #5496