Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort task groups reverse alphabetically by their status #6886

Merged
merged 4 commits into from
Sep 9, 2024
Merged

sort task groups reverse alphabetically by their status #6886

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
641b33d
sort task groups reverse alphabetically by their status
kbavi Sep 3, 2024
2bf4388
Merge branch 'main' into sort-taskgroup-by-status
lucasbordeau Sep 9, 2024
28f0aea
Small refactor
lucasbordeau Sep 9, 2024
2ccbed4
Minor fixes
lucasbordeau Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions packages/twenty-front/src/modules/activities/tasks/components/TaskGroups.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,19 +93,25 @@ export const TaskGroups = ({

return (
<StyledContainer>
{Object.entries(groupBy(tasks, ({ status }) => status)).map(
([status, tasksByStatus]: [string, Task[]]) => (
<TaskList
key={status}
title={status}
tasks={tasksByStatus}
button={
showAddButton && (
<AddTaskButton activityTargetableObjects={targetableObjects} />
)
}
/>
),
{
Object.entries(groupBy(tasks, ({ status }) => status))
.toSorted(
// maintains order of status as TODO -> IN_PROGRESS -> DONE (which is coincidentally reverse alphabetical)
([statusA], [statusB]) => (statusB.localeCompare(statusA))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Handle potential null statuses to prevent runtime errors

)
.map(
([status, tasksByStatus]: [string, Task[]]) => (
<TaskList
key={status}
title={status}
tasks={tasksByStatus}
button={
showAddButton && (
<AddTaskButton activityTargetableObjects={targetableObjects} />
)
}
/>
),
)}
</StyledContainer>
);
Expand Down
Loading