-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow nodes configuration #6861
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
dae5f76
feat: allow only a single serverless function action type to be selected
Devessier e2b1164
feat: get selected node's definition
Devessier e220ab9
feat: allow updating triggers
Devessier b0c5a70
feat: allow updating the configuration of code action steps
Devessier 036ac3d
refactor: extract step manipulation functions in separate files
Devessier 579866a
test: write tests for the replaceStep function
Devessier aa21843
fix: solve merge conflicts artifacts
Devessier b570931
fix: don't break adding steps when no step was created yet
Devessier ea250e9
refactor: rename the hook to create new steps
Devessier 542a155
feat: load last published version or draft version conditionally
Devessier 64d20b5
feat: allow none value for serverless function
Devessier 8c0bbb3
feat: set a better label to trigger nodes
Devessier 06ba5a2
feat: fetch draft and published versions and choose which one to use …
Devessier 6b8c2f0
refactor: reuse utility function to find a step
Devessier 90cfc67
refactor: extract code to update triggers and steps in hooks
Devessier a9cfbe1
refactor: delete useless container element
Devessier 38f2f86
refactor: centralize how we extract object and event types from trigg…
Devessier 3bd7331
refactor: use globally defined constant representing the id of trigge…
Devessier f78c588
refactor: remove unwanted comments
Devessier 6fe63bf
test: fix failing test
Devessier 2c9b4e5
test: fix failing tests
Devessier 8d530dc
refactor: replace triple-equal checks with calls to the isDefined fun…
Devessier fb3cfb0
refactor: rename variable
Devessier 9055cd9
fix: fetch only the draft versions for the workflow we want
Devessier f41923c
refactor: throw inside getStepDefinition function
Devessier 87ed28a
refactor: extract getStepDefaultDefinition function to its own file
Devessier bdf823e
refactor: fetch the most recently created workflow version and use it…
Devessier c6f4273
refactor: rename the hook for consistency
Devessier 8fe896c
refactor: inline overkill custom hook
Devessier 29ba4e4
fix: allow user to select only serverless function that have ever bee…
Devessier 2f0a68b
refactor: delete unused states
Devessier 6fae825
refactor: rename workflow diagram state
Devessier 0b89e6e
refactor: rename the state
Devessier c4b5adb
refactor: rename workflow id state
Devessier 1d3be26
refactor: rename workflow selected node state
Devessier 7a81a6f
refactor: rename diagram component
Devessier 5346d85
refactor: rename the custom nodes components
Devessier cca7ec8
refactor: rename effect component
Devessier 2f4251c
refactor: rename the hook that creates steps
Devessier a3d1035
refactor: rename the components for workflow actions and triggers edi…
Devessier 0fbf4ed
refactor: simplify ids
Devessier 7a96ab6
refactor: extract the static list of available actions in another file
Devessier cbe7030
fix: fix typo in path
Devessier 7d0c695
refactor: extract static array in separate file
Devessier 03a7375
refactor: give a better name to variables
Devessier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: centralize how we extract object and event types from trigg…
…er event name
- Loading branch information
commit 38f2f860b8feae5cec26922a59a683c203b40115
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
packages/twenty-front/src/modules/workflow/utils/splitWorkflowTriggerEventName.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
export const splitWorkflowTriggerEventName = (eventName: string) => { | ||
const [objectType, event] = eventName.split('.'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Add a check for empty string input to prevent potential issues |
||
|
||
return { | ||
objectType, | ||
event, | ||
}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for all those id names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done