-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to filter by composite's subfields #6832
Ability to filter by composite's subfields #6832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request is a work in progress (WIP) that aims to update the UI to allow filtering by composite sub-fields, addressing issue #6445 related to Objects/Fields improvements.
- Implements filtering functionality for composite sub-fields in the UI
- Addresses a specific aspect of the larger Objects/Fields Master Issue (Objects/Fields Master Issue #6445)
- Part of the "Fields Filtering / Sorting" category in the master issue tasklist
- No specific file changes are provided in the current state of the PR
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@charlesBochet @Bonapara |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ges/twenty-front/src/modules/object-record/object-filter-dropdown/utils/getSubMenuOptions.ts
Outdated
Show resolved
Hide resolved
...nt/src/modules/object-record/object-filter-dropdown/components/ObjectFilterSelectSubMenu.tsx
Outdated
Show resolved
Hide resolved
...nt/src/modules/object-record/object-filter-dropdown/components/ObjectFilterSelectSubMenu.tsx
Outdated
Show resolved
Hide resolved
...modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownFilterSelect.tsx
Outdated
Show resolved
Hide resolved
...ages/twenty-front/src/modules/object-record/object-filter-dropdown/utils/isCompositeField.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-filter/utils/applyEmptyFilters.ts
Show resolved
Hide resolved
...nty-front/src/modules/object-record/record-filter/utils/getCorrespondingSubfieldFromLabel.ts
Outdated
Show resolved
Hide resolved
...nty-front/src/modules/object-record/record-filter/utils/getCorrespondingSubfieldFromLabel.ts
Outdated
Show resolved
Hide resolved
Thank you for the reviews @martmull |
Do we have any figma design for this ui/ux @martmull ? |
@pacyL2K19, @Bonapara is updating the figma. We think this go back arrow will be required in all fields, not only subfields. So it deserves its own ticket. Lets not pass the changes in that PR, you can resolve this comment, thanks |
Thanks @pacyL2K19 for your contribution! |
# This PR - Fix twentyhq#6425 See twentyhq#7188 because there's some more work to do. --------- Co-authored-by: Lucas Bordeau <[email protected]>
This PR
See #7188 because there's some more work to do.