Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Website build CD #6751

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Fix Website build CD #6751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04075c3
Test build front without checkers
charlesBochet Aug 27, 2024
cfdd37b
Fix website build CD
charlesBochet Aug 27, 2024
61c548f
Fix
charlesBochet Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@
"tslib": "^2.3.0",
"tsup": "^8.2.4",
"type-fest": "4.10.1",
"typeorm": "patch:[email protected]#./packages/twenty-server/patches/typeorm+0.3.20.patch",
"typescript": "5.3.3",
"use-context-selector": "^2.0.0",
"use-debounce": "^10.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/twenty-front/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"type": "module",
"scripts": {
"build": "npx vite build && sh ./scripts/inject-runtime-env.sh",
"build": "VITE_DISABLE_TYPESCRIPT_CHECKER=true VITE_DISABLE_ESLINT_CHECKER=true npx vite build && sh ./scripts/inject-runtime-env.sh",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Disabling TypeScript and ESLint checkers may lead to undetected errors in production. Consider alternative solutions that maintain these checks.

"build:sourcemaps": "VITE_BUILD_SOURCEMAP=true VITE_DISABLE_TYPESCRIPT_CHECKER=true VITE_DISABLE_ESLINT_CHECKER=true NODE_OPTIONS=--max-old-space-size=6000 npx nx build",
"start:prod": "NODE_ENV=production npx vite --host",
"tsup": "npx tsup"
Expand Down
6 changes: 6 additions & 0 deletions packages/twenty-front/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ export default defineConfig(({ command, mode }) => {
overlay: false,
};

console.log(
`VITE_DISABLE_TYPESCRIPT_CHECKER: ${VITE_DISABLE_TYPESCRIPT_CHECKER}`,
);
console.log(`VITE_DISABLE_ESLINT_CHECKER: ${VITE_DISABLE_ESLINT_CHECKER}`);
console.log(`VITE_BUILD_SOURCEMAP: ${VITE_BUILD_SOURCEMAP}`);

if (VITE_DISABLE_TYPESCRIPT_CHECKER !== 'true') {
checkers['typescript'] = {
tsconfigPath: tsConfigPath,
Expand Down
1 change: 1 addition & 0 deletions packages/twenty-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"passport": "^0.7.0",
"psl": "^1.9.0",
"tsconfig-paths": "^4.2.0",
"typeorm": "patch:[email protected]#./patches/typeorm+0.3.20.patch",
"zod-to-json-schema": "^3.23.1"
},
"devDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47108,6 +47108,7 @@ __metadata:
psl: "npm:^1.9.0"
rimraf: "npm:^5.0.5"
tsconfig-paths: "npm:^4.2.0"
typeorm: "patch:[email protected]#./patches/typeorm+0.3.20.patch"
typescript: "npm:5.3.3"
zod-to-json-schema: "npm:^3.23.1"
languageName: unknown
Expand Down Expand Up @@ -47468,7 +47469,6 @@ __metadata:
tsup: "npm:^8.2.4"
tsx: "npm:^4.17.0"
type-fest: "npm:4.10.1"
typeorm: "patch:[email protected]#./packages/twenty-server/patches/typeorm+0.3.20.patch"
typescript: "npm:5.3.3"
use-context-selector: "npm:^2.0.0"
use-debounce: "npm:^10.0.0"
Expand Down Expand Up @@ -47679,9 +47679,9 @@ __metadata:
languageName: node
linkType: hard

"typeorm@patch:[email protected]#./packages/twenty-server/patches/typeorm+0.3.20.patch::locator=twenty%40workspace%3A.":
"typeorm@patch:[email protected]#./patches/typeorm+0.3.20.patch::locator=twenty-server%40workspace%3Apackages%2Ftwenty-server":
version: 0.3.20
resolution: "typeorm@patch:typeorm@npm%3A0.3.20#./packages/twenty-server/patches/typeorm+0.3.20.patch::version=0.3.20&hash=d5f43a&locator=twenty%40workspace%3A."
resolution: "typeorm@patch:typeorm@npm%3A0.3.20#./patches/typeorm+0.3.20.patch::version=0.3.20&hash=d5f43a&locator=twenty-server%40workspace%3Apackages%2Ftwenty-server"
dependencies:
"@sqltools/formatter": "npm:^1.2.5"
app-root-path: "npm:^3.1.0"
Expand Down
Loading