Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch messaging import crons not running #6688

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Aug 19, 2024

In 0.23.1, we have introduced a regression by migrating to TwentyORM ; messageChannels were not considered as syncable anymore.

I'm also using this PR to fix the channelStatus monitoring script

@charlesBochet charlesBochet merged commit 12a657c into main Aug 19, 2024
3 of 4 checks passed
@charlesBochet charlesBochet deleted the patch-on-main-messaging branch August 19, 2024 17:19
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses a regression in version 0.23.1 related to message channel synchronization, fixing issues introduced during the migration to TwentyORM.

  • Modified messaging-message-list-fetch.cron.job.ts to fetch all message channel fields, enabling proper sync status checks
  • Corrected parameter order in messaging-message-channel-sync-status-monitoring.cron.ts for accurate repository retrieval
  • Both changes ensure message channels are correctly identified as syncable, restoring functionality to messaging import crons
  • Fixes affect active workspaces and their associated message channels across the system
  • Resolves potential data inconsistencies and missed synchronizations due to incomplete message channel information

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet restored the patch-on-main-messaging branch August 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant