added reply button in email threads #6642
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements the 'Reply (View in Gmail)' button functionality for email threads, addressing issue #4217. The changes focus on integrating Gmail redirection within the email thread view.
- Added 'Reply (View in Gmail)' button in RightDrawerEmailThread component
- Implemented useRightDrawerEmailThread hook to fetch messageThreadExternalId for Gmail URL construction
- Created new MessageThreadExternalId type and added MessageChannelMessageAssociation to CoreObjectNameSingular enum
- Updated EmailThreadMessageParticipant type to include messageId field
- Modified fetchAllThreadMessagesOperationSignatureFactory to include messageId in the query
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| ]; | ||
| const lastMessageId = lastParticipant?.messageId; | ||
|
|
||
| const { |
There was a problem hiding this comment.
style: Consider adding pagination or limiting the number of records fetched for messageThreadExternalIdsData to optimize performance
...s/twenty-front/src/modules/activities/emails/right-drawer/hooks/useRightDrawerEmailThread.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/emails/types/MessageThreadExternalId.ts
Outdated
Show resolved
Hide resolved
...s/twenty-front/src/modules/activities/emails/right-drawer/hooks/useRightDrawerEmailThread.ts
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/activities/emails/right-drawer/components/RightDrawerEmailThread.tsx
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/activities/emails/right-drawer/components/RightDrawerEmailThread.tsx
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/activities/emails/right-drawer/components/RightDrawerEmailThread.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the review @lucasbordeau ! |
| } | ||
|
|
||
| const userEmail = currentUser?.email; | ||
| const url = `https://mail.google.com/mail/?authuser=${userEmail}#all/${messageThreadExternalId}`; |
There was a problem hiding this comment.
Here it would help to put not the userEmail but the connected account related to this thread.
For example I connected a second gmail account and when I clicked on reply it tried to open the first default demo [email protected] account (which doesn't exist)
There was a problem hiding this comment.
In my case, if I connect a second gmail account with then default [email protected], emails dont get imported for the second gmail account. Idk if thats a bug from my end.
I am running these cron jobs -
npx nx run twenty-server:command cron:messaging:messages-import
npx nx run twenty-server:command cron:messaging:message-list-fetch
These jobs are it right? or are there anymore?
But it does make sense to have connected account related to the thread to be populated here.
Issue is I couldnt find a connected account related to that thread or message table.
How do i get the connected account related to that thread?
Need help :(
There was a problem hiding this comment.
You have to run the worker with :
yarn nx worker twenty-server (it will process the jobs)
Then create the cron with : npx nx run twenty-server:command cron:messaging:messages-import
There was a problem hiding this comment.
I do run worker using npx nx run twenty-server:worker and then cron jobs.
Ill check them once more however I cant find a connected account related to that thread or message table.
How do i get the connected account related to that thread?
|
Could you confirm if this is whats happening.
It gets populated only for the account we are signing in.
|
|
@ehconitin Could you contact me on Discord ? It would be easier to solve this. Could you check that you have those options also : 
|
ehconitin
force-pushed
the
fixed-issue-4217
branch
from
39ef0c1 to
374931b
Compare
|
my bad @lucasbordeau |
Issue #4217
Please let me know what do you think.