Migrate to workspace services #6628
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request migrates various services in the workflow module to workspace-specific services, improving modularity and multi-tenancy support.
- Renamed services to include "Workspace" (e.g.,
WorkflowTriggerServicetoWorkflowTriggerWorkspaceService) across multiple files - Removed
workspaceIdparameter from method signatures, suggesting workspace context is now handled at a higher level - Introduced
ScopedWorkspaceContextFactoryinpackages/twenty-server/src/modules/workflow/workflow-action-runner/workflow-action-runner.module.ts - Replaced
TwentyORMGlobalManagerwithTwentyORMManagerfor database interactions - Added
WorkflowActionRunnerExceptioninpackages/twenty-server/src/modules/workflow/workflow-action-runner/workflow-action-runner.exception.tsfor better error handling
12 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
| async enableWorkflowTrigger( | ||
| @AuthWorkspace() { id: workspaceId }: Workspace, | ||
| @Args('workflowVersionId') workflowVersionId: string, | ||
| ) { |
There was a problem hiding this comment.
logic: workspaceId parameter removed. Ensure workspace context is correctly handled by WorkflowTriggerWorkspaceService
| async runWorkflowVersion( | ||
| @AuthWorkspace() { id: workspaceId }: Workspace, | ||
| @Args('input') { workflowVersionId, payload }: RunWorkflowVersionInput, | ||
| ) { |
There was a problem hiding this comment.
logic: workspaceId parameter removed here as well. Verify that WorkflowTriggerWorkspaceService correctly identifies the workspace context
| @@ -0,0 +1,12 @@ | |||
| import { CustomException } from 'src/utils/custom-exception'; | |||
There was a problem hiding this comment.
style: Consider using a relative import path for better maintainability
| import { CustomException } from 'src/utils/custom-exception'; | ||
|
|
||
| export class WorkflowActionRunnerException extends CustomException { | ||
| code: WorkflowActionRunnerExceptionCode; |
There was a problem hiding this comment.
style: The code property is redundant as it's already defined in the constructor parameter
As title