-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6619 modify event emitter to emit an array of events #6625
6619 modify event emitter to emit an array of events #6625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request modifies the event emitter system to handle arrays of events instead of single events across multiple files in the twentyhq/twenty repository.
- Introduced new
WorkspaceEventEmitter
class andWorkspaceEventBatch
type to support batch event processing - Updated all listeners to handle arrays of events, improving efficiency through concurrent processing
- Modified
WorkspaceQueryRunnerService
to use the newWorkspaceEventEmitter
for batch event emission - Removed 'name' and 'workspaceId' properties from
ObjectRecordBaseEvent
, now handled at the batch level - Adjusted various services and listeners to work with the new batch event structure, maintaining core functionality
26 file(s) reviewed, 25 comment(s)
Edit PR Review Bot Settings
...rver/src/engine/api/graphql/workspace-query-runner/listeners/entity-events-to-db.listener.ts
Outdated
Show resolved
Hide resolved
...rver/src/engine/api/graphql/workspace-query-runner/listeners/entity-events-to-db.listener.ts
Outdated
Show resolved
Hide resolved
.../twenty-server/src/engine/api/graphql/workspace-query-runner/listeners/telemetry.listener.ts
Show resolved
Hide resolved
.../twenty-server/src/engine/api/graphql/workspace-query-runner/listeners/telemetry.listener.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user/services/user.service.ts
Show resolved
Hide resolved
...dules/messaging/message-participant-manager/listeners/message-participant-person.listener.ts
Show resolved
Hide resolved
...dules/messaging/message-participant-manager/listeners/message-participant-person.listener.ts
Show resolved
Hide resolved
...dules/messaging/message-participant-manager/listeners/message-participant-person.listener.ts
Show resolved
Hide resolved
...aging/message-participant-manager/listeners/message-participant-workspace-member.listener.ts
Outdated
Show resolved
Hide resolved
...aging/message-participant-manager/listeners/message-participant-workspace-member.listener.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations!
Closes #6619