Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6619 modify event emitter to emit an array of events #6625

Merged

Conversation

bosiraphael
Copy link
Contributor

Closes #6619

@bosiraphael bosiraphael linked an issue Aug 14, 2024 that may be closed by this pull request
@charlesBochet charlesBochet self-assigned this Aug 14, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request modifies the event emitter system to handle arrays of events instead of single events across multiple files in the twentyhq/twenty repository.

  • Introduced new WorkspaceEventEmitter class and WorkspaceEventBatch type to support batch event processing
  • Updated all listeners to handle arrays of events, improving efficiency through concurrent processing
  • Modified WorkspaceQueryRunnerService to use the new WorkspaceEventEmitter for batch event emission
  • Removed 'name' and 'workspaceId' properties from ObjectRecordBaseEvent, now handled at the batch level
  • Adjusted various services and listeners to work with the new batch event structure, maintaining core functionality

26 file(s) reviewed, 25 comment(s)
Edit PR Review Bot Settings

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

@charlesBochet charlesBochet merged commit 091c0f8 into main Aug 20, 2024
3 of 4 checks passed
@charlesBochet charlesBochet deleted the 6619-modify-event-emitter-to-emit-an-array-of-events branch August 20, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify event emitter to emit an array of events
2 participants