Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed modal clickoutside #6624

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fixed modal clickoutside #6624

merged 1 commit into from
Aug 14, 2024

Conversation

lucasbordeau
Copy link
Contributor

Modal clickoutside was modified recently.

It was considering portaled component like dropdown outside, so comparePixel mode for click outside is needed here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request modifies the Modal component to improve click outside detection, addressing issues with portaled components like dropdowns.

  • Implemented ClickOutsideMode.comparePixels in useListenClickOutsideV2 hook for Modal component
  • Enhanced accuracy of click outside detection, particularly for elements rendered outside modal's DOM hierarchy
  • Prevents unintended modal closures when interacting with portaled UI elements
  • Addresses recent changes to modal click outside behavior that affected dropdown interactions

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit 121794e into main Aug 14, 2024
11 of 13 checks passed
@charlesBochet charlesBochet deleted the fix/import-csv branch August 14, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants