Add workflow run entity #6622
Merged
Add workflow run entity #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomtrp
commented
Aug 14, 2024
thomtrp
commented
- create a workflow run every time a workflow is triggered in not_started status. This status will be helpful later for once workflows will be scheduled
- update run status once workflow starts running
- complete status once the workflow finished running
- add a failed status if an error occurs
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a new WorkflowRunWorkspaceEntity to track the execution of workflows, implementing functionality to create, update, and manage workflow run statuses throughout the workflow execution process.
- Added WorkflowRunWorkspaceEntity in
workflow-run.workspace-entity.tswith fields for start/end times and status - Implemented WorkflowStatusService in
workflow-status.service.tsto manage workflow run lifecycle (create, start, end) - Updated WorkflowRunnerJob in
workflow-runner.job.tsto use WorkflowStatusService for tracking run progress - Modified WorkflowEventTriggerJob in
workflow-event-trigger.job.tsto create a workflow run before execution - Introduced WorkflowStatusException in
workflow-status.exception.tsfor handling specific workflow status errors
13 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
| icon: 'IconHistory', | ||
| }) | ||
| @WorkspaceIsNullable() | ||
| status: WorkflowRunStatus; |
There was a problem hiding this comment.
style: Consider making status non-nullable to ensure it always has a valid value
.../twenty-server/src/modules/workflow/common/standard-objects/workflow-run.workspace-entity.ts
Show resolved
Hide resolved
Comment on lines
26
to
34
| const onGoingWorkflowRuns = ( | ||
| await workflowRunDataSource.findBy({ | ||
| workflowVersionId, | ||
| }) | ||
| ).filter((workflow) => | ||
| [WorkflowRunStatus.NOT_STARTED, WorkflowRunStatus.RUNNING].includes( | ||
| workflow.status, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
style: Consider using a database query to filter ongoing workflow runs instead of fetching all and filtering in memory. This approach may not scale well with a large number of workflow runs.
|
|
||
| if (onGoingWorkflowRuns.length > 0) { | ||
| throw new WorkflowStatusException( | ||
| 'There is already an on going workflow run', |
There was a problem hiding this comment.
syntax: 'on going' should be 'ongoing'
Suggested change
| 'There is already an on going workflow run', | |
| 'There is already an ongoing workflow run', |
thomtrp
force-pushed
the
tt-follow-workflow-status
branch
from
a2fd157
to
e4ed6e1
Compare
charlesBochet
approved these changes
Aug 14, 2024
.../twenty-server/src/modules/workflow/common/standard-objects/workflow-run.workspace-entity.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-runner/workflow-runner.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-status/workflow-status.module.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-trigger/jobs/workflow-event-trigger.job.ts
Show resolved
Hide resolved
...ages/twenty-server/src/modules/workflow/workflow-trigger/jobs/workflow-trigger-job.module.ts
Outdated
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-follow-workflow-status
branch
from
f5e87d9
to
b80e83b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.