-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exclude tabler/icons-react from optimizeDeps to avoid crashing performance CI #6621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses slow loading times and potential crashes in Storybook by modifying the Vite configuration to exclude '@tabler/icons-react' from dependency optimization.
- Added
optimizeDeps: { exclude: ['@tabler/icons-react'] }
inpackages/twenty-front/vite.config.ts
- This change aims to reduce load times for stories, particularly those using Linaria components
- Addresses the Babel deoptimization warning for large files (>500KB) mentioned in issue Problem with Babel, wyw-in-js and Linaria with Storybook #6437
- May help prevent performance CI crashes related to Storybook loading
- Further investigation needed to compare loading times between Linaria and non-Linaria components
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Thanks @Nabhag8848 for your contribution! |
ISSUE (Warning)
Things needed to investigate :