Create default view for workflows + fix task and note targets #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
approved these changes
Aug 14, 2024
| ) => { | ||
| const IsWorkflowEnabled = |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements a new default view for workflows and enhances the relationships between workflows, tasks, and notes. Here are the key changes:
- Added a new 'All Workflows' view in
workflows-all.view.ts, displaying workflow name and published version ID - Integrated the new workflows view into the
viewPrefillDatafunction, gated by the IsWorkflowEnabled feature flag - Extended NoteTargetWorkspaceEntity and TaskTargetWorkspaceEntity to include a relation to WorkflowWorkspaceEntity
- Updated WorkflowWorkspaceEntity to include one-to-many relations with taskTargets and noteTargets
- Modified data seeding process to support feature flag-based view creation for workflows
7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
23
to
26
| const IsWorkflowEnabled = | ||
| featureFlags?.find( | ||
| (featureFlag) => featureFlag.key === FeatureFlagKey.IsWorkflowEnabled, | ||
| )?.value ?? false; |
There was a problem hiding this comment.
style: Consider using a more descriptive variable name like 'isWorkflowEnabled' (camelCase) instead of 'IsWorkflowEnabled'
Comment on lines
+5
to
+7
| export const workflowsAllView = async ( | ||
| objectMetadataMap: Record<string, ObjectMetadataEntity>, | ||
| ) => { |
There was a problem hiding this comment.
style: Consider adding JSDoc comment for function description and parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title