5x Fix cache performance issues #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses significant cache performance issues by optimizing the handling of object metadata in the Twenty ORM system.
- Introduced
objectMetadataCollectioninWorkspaceInternalContextto reduce repeated calls togetObjectMetadata - Modified
WorkspaceDatasourceFactoryto instantiateobjectMetadataCollectiononce per workspace - Refactored
determineRelationDetailsfunction inentity-schema-relation.factory.tsto use the newobjectMetadataCollection - Updated
WorkspaceRepositoryclass for more efficient data retrieval and improved error handling - Achieved substantial performance improvements, reducing query times (e.g., TimelineCalendar queries from ~450ms to 80ms)
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
packages/twenty-server/src/engine/twenty-orm/repository/workspace.repository.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/twenty-orm/utils/determine-relation-details.util.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getObjectMetadatafromWorkspaceCacheStorageServicein every query was causing big performance issues. TheobjectMetadataCollectionis now part of theWorkspaceInternalContextso we only instance it once in theWorkspaceDatasourceFactory.Queries are now much faster, for instance for TimelineCalendar, it went from ~450ms to 80ms.