Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column overlay issue in record table header cells #6609

Merged

Conversation

Nabhag8848
Copy link
Contributor

@Nabhag8848 Nabhag8848 commented Aug 11, 2024

Issue (BUG)

Description

  • Now Columns doesn't overlay on header cells, issue was independant of field type.

Before

Screen.Recording.2024-08-11.at.2.22.13.PM.mov

After

Screen.Recording.2024-08-11.at.3.35.47.PM.mov

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The PR resolves the issue of column names overlapping in the record table header cells by adjusting the styling of the StyledIcon and header cell components.

  • Added flex-shrink: 0 to StyledIcon in /packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableColumnHead.tsx to prevent icon shrinking.
  • Applied overflow: hidden to the div within the styled column header cell in /packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderCell.tsx to ensure long column names do not spill over.
  • Changes are minimal and focused, maintaining consistency with existing styled-components and state management patterns.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Nabhag8848
Copy link
Contributor Author

@CoreTeamTwenty 🔥 ready for review

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you!

@FelixMalfait FelixMalfait merged commit b16437e into twentyhq:main Aug 11, 2024
9 of 11 checks passed
Copy link

Thanks @Nabhag8848 for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column's name overlays other column's name
2 participants