Use twentyORM in Timeline messaging #6595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored timeline messaging to use twentyORM instead of raw queries, enhancing maintainability and modularity.
timeline-thread-participant.dto.ts: MadepersonIdandworkspaceMemberIdnullable to align with GraphQL schema.get-messages-from-company-id.service.ts: Introduced service to fetch messages by company ID usingtwentyORM.get-messages-from-person-ids.service.ts: Added service to retrieve messages by person IDs, leveragingtwentyORM.timeline-messaging.service.ts: Refactored to usetwentyORMfor fetching message threads and visibility.timeline-messaging.module.ts: Updated to include new services for handling messages from company and person IDs.
11 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings
...ty-server/src/engine/core-modules/messaging/services/get-messages-from-company-id.service.ts
Outdated
Show resolved
Hide resolved
| ): Promise<{ | ||
| [key: string]: MessageChannelVisibility; | ||
| }> { | ||
| const messageThreadIdsForWhichWorkspaceMemberIsNotInParticipants = |
There was a problem hiding this comment.
style: Consider optimizing the reduce function for better performance.
packages/twenty-server/src/engine/core-modules/messaging/timeline-messaging.resolver.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/messaging/timeline-messaging.resolver.ts
Outdated
Show resolved
Hide resolved
...es/twenty-server/src/engine/core-modules/messaging/utils/extract-participant-summary.util.ts
Outdated
Show resolved
Hide resolved
...ages/twenty-server/src/engine/core-modules/messaging/utils/format-thread-participant.util.ts
Show resolved
Hide resolved
...ages/twenty-server/src/engine/core-modules/messaging/utils/format-thread-participant.util.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/messaging/utils/format-threads.util.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/messaging/utils/format-threads.util.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twentyORM