Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook tests #6594

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Fix storybook tests #6594

merged 7 commits into from
Aug 9, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Aug 9, 2024

As title

@thomtrp thomtrp marked this pull request as ready for review August 9, 2024 16:16
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request 'Fix storybook tests' includes changes to multiple Storybook test files to improve test reliability and consistency.

  • packages/twenty-front/src/loading/components/__stories__/PrefetchLoading.stories.tsx: Removed PrefetchLoadingDecorator and updated assertions to check for the presence of text elements.
  • packages/twenty-front/src/modules/command-menu/components/__stories__/CommandMenu.stories.tsx: Reordered imports, removed unused mocks, and updated test scenarios.
  • packages/twenty-front/src/modules/object-metadata/components/__stories__/ObjectMetadataNavItems.stories.tsx: Added PrefetchLoadedDecorator to ensure prefetch states are set.
  • packages/twenty-front/src/modules/settings/data-model/fields/preview/components/__stories__/SettingsDataModelFieldPreviewCard.stories.tsx: Renamed 'Link' story to 'Links' and updated field type.
  • packages/twenty-front/src/testing/decorators/PrefetchLoadedDecorator.tsx: Introduced a new decorator to set prefetch states for views and favorites using Recoil.

8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@thomtrp thomtrp merged commit 39512a7 into main Aug 9, 2024
11 of 13 checks passed
@thomtrp thomtrp deleted the tt-fix-storybook-tests branch August 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants