Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code linked to quick actions #6587

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

FelixMalfait
Copy link
Member

Removing dead code, we'll take another approach to build this

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request removes dead code related to quick actions, including hooks, tests, and associated GraphQL mutations, to streamline the codebase.

  • Removed Hooks and Tests: Deleted useExecuteQuickActionOnOneRecord.ts, useExecuteQuickActionOnOneRecordMutation.ts, and their associated test files from packages/twenty-front/src/modules/object-record/hooks.
  • Updated useRecordActionBar.tsx: Removed references to quick actions, including the handleExecuteQuickActionOnClick function and the useExecuteQuickActionOnOneRecord hook.
  • Removed Server-Side Quick Actions: Deleted execute-quick-action-on-one-resolver.factory.ts, quick-actions.module.ts, and quick-actions.service.ts from packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder.
  • Feature Flag Removal: Removed IS_QUICK_ACTIONS_ENABLED from packages/twenty-front/src/modules/workspace/types/FeatureFlagKey.ts.
  • Environment Variable Cleanup: Removed OPENROUTER_API_KEY from packages/twenty-server/src/engine/integrations/environment/environment-variables.ts.

21 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@FelixMalfait FelixMalfait merged commit 7e01843 into main Aug 9, 2024
11 of 14 checks passed
@FelixMalfait FelixMalfait deleted the remove-quick-actions branch August 9, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant