Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend tests #6585

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Fix frontend tests #6585

merged 7 commits into from
Aug 9, 2024

Conversation

FelixMalfait
Copy link
Member

Fix a few broken tests

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request addresses broken frontend tests by making syntax adjustments, modifying error handling types, and updating mock data.

  • Toggle.tsx: Added parentheses around a ternary operation in the styled component definition to ensure proper evaluation order.
  • apollo.factory.ts: Changed onError callback type from GraphQLFormattedError to readonly GraphQLFormattedError[] to handle multiple errors.
  • metadata.ts: Updated the id field of a priority option from '3' to '6f6e1421-8a42-4d4a-bf76-465b5f84b6d2' to align mock data with test expectations.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@FelixMalfait FelixMalfait merged commit f2cc385 into main Aug 9, 2024
13 of 16 checks passed
@FelixMalfait FelixMalfait deleted the fix-some-tests branch August 9, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant