Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perf tests storybook #6584

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix perf tests storybook #6584

merged 1 commit into from
Aug 8, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Aug 8, 2024

As title

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request focuses on fixing performance tests in Storybook for various field display components by updating decorators, mock data, and ensuring alignment with the correct data structures.

  • ActorFieldDisplay: Updated getFieldDecorator to use 'company' with 'createdBy' field. (/packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/__stories__/perf/ActorFieldDisplay.perf.stories.tsx)
  • AddressFieldDisplay: Enhanced mock data with specific address details. (/packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/__stories__/perf/AddressFieldDisplay.perf.stories.tsx)
  • BooleanFieldDisplay: Aligned decorator to use 'company' and 'idealCustomerProfile'. (/packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/__stories__/perf/BooleanFieldDisplay.perf.stories.tsx)
  • JsonFieldDisplay: Updated decorators for realistic test data. (/packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/__stories__/perf/JsonFieldDisplay.perf.stories.tsx)
  • getFieldDecorator: Added support for handling tasks. (/packages/twenty-front/src/testing/decorators/getFieldDecorator.tsx)

11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@FelixMalfait FelixMalfait merged commit ab12d9e into main Aug 8, 2024
5 of 11 checks passed
@FelixMalfait FelixMalfait deleted the tt-fix-perf-tests-sb branch August 8, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants