removed @blocknote/core from dependencies #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request removes the @blocknote/core dependency from package.json, addressing issues with block duplication and bullet point indentation in the RichTextEditor.
- Removed
@blocknote/corefrompackage.json. - Updated
/packages/twenty-front/src/modules/activities/components/RichTextEditor.tsxto handle block movements and indentation without@blocknote/core. - Ensured
BlockEditorand related components in/packages/twenty-front/src/modules/ui/input/editor/components/BlockEditor.tsxfunction correctly without@blocknote/core. - Verified that all imports and usages of
@blocknote/coreare properly handled to avoid runtime errors.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
The pull request removes the @blocknote/core dependency from package.json, addressing issues with block duplication and bullet point indentation in the RichTextEditor.
- Removed
@blocknote/corefrompackage.json. - Updated
/packages/twenty-front/src/modules/activities/components/RichTextEditor.tsxto handle block movements and indentation without@blocknote/core. - Ensured
BlockEditorand related components in/packages/twenty-front/src/modules/ui/input/editor/components/BlockEditor.tsxfunction correctly without@blocknote/core. - Verified that all imports and usages of
@blocknote/coreare properly handled to avoid runtime errors.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Thanks @ehconitin for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6564 & #6561
@FelixMalfait
Removed @blocknote/core from dependencies
2024-08-08.16-33-36.mp4