6430 Part 1: remove all raw queries from the messaging and calendar modules #6572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! FYI merge conflict with main |
…ng-and-calendar-modules
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request removes raw queries from the messaging and calendar modules, replacing them with ORM-based queries using twentyORMManager.
- Removed Repositories: Deleted
message-channel.repository.ts,message-participant.repository.ts,message-thread.repository.ts, andmessage.repository.tsto eliminate raw queries. - Updated Services: Replaced raw queries with ORM methods in
google-apis.service.ts,messaging-channel-sync-status.service.ts, andmessaging-messages-import.service.ts. - Modified Jobs: Updated
messaging-blocklist-item-delete-messages.job.tsandmessaging-message-list-fetch.cron.job.tsto usetwentyORMManager. - Listener Changes:
messaging-blocklist.listener.tsnow uses ORM for repository access. - Module Adjustments: Removed raw query-based entities from
auth.module.tsandmessaging-common.module.ts.
26 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
approved these changes
Aug 13, 2024
charlesBochet
deleted the
6430-remove-all-raw-queries-from-the-messaging-and-calendar-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #6430
messagingmoduletwentyORMManager