Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createdBy and activity tests #6569

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Aug 7, 2024

As title

@Weiko
Copy link
Member

Weiko commented Aug 7, 2024

LGTM, could use "fragments" (mocks) for composite fields but it's not really important 👍

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request updates various test files and mock data to align with changes in GraphQL mutations and object structures, particularly focusing on the 'createdBy' field and activity hooks.

  • /packages/twenty-front/src/modules/activities/hooks/__tests__/useCreateActivityInDB.test.tsx: Updated mutation from createActivity to createTask to reflect application changes.
  • /packages/twenty-front/src/modules/activities/tasks/hooks/__tests__/useCompleteTask.test.tsx: Mutation now targets updateTask instead of updateActivity, ensuring task status updates correctly.
  • /packages/twenty-front/src/modules/favorites/hooks/__mocks__/useFavorites.ts: Expanded mock data and mutations to include detailed fields like taskId, workspaceMemberId, and nested objects.
  • /packages/twenty-front/src/modules/object-record/hooks/__mocks__/useCreateManyRecords.ts: Added fields such as updatedAt, myCustomObjectId, and createdBy in the mutation for creating people records.
  • /packages/twenty-front/src/modules/object-record/hooks/__mocks__/useCreateOneRecord.ts: Expanded mutation CreateOnePerson to include additional fields like whatsapp, linkedinLink, and performanceRating.

18 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weiko Weiko merged commit 9a0c967 into main Aug 7, 2024
6 of 12 checks passed
@Weiko Weiko deleted the tt-fix-createdBy-and-activity-tests branch August 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants