Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ts-error-fixes #6563

Merged
merged 1 commit into from
Aug 7, 2024
Merged

some ts-error-fixes #6563

merged 1 commit into from
Aug 7, 2024

Conversation

ehconitin
Copy link
Contributor

@FelixMalfait

Let me know what do you think.

Thanks

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request focuses on fixing TypeScript errors and improving code readability through variable renaming, import reordering, and adding null checks.

  • /packages/twenty-front/src/modules/object-record/record-field/meta-types/hooks/useActorFieldDisplay.ts: Renamed entityId to recordId for consistency.
  • /packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/RelationFromManyFieldInput.tsx: Updated to use recordId instead of entityId from FieldContext.
  • /packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCell.tsx: Addressed TypeScript errors and improved import order and formatting.
  • /packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx: Reordered imports and reformatted function calls for better readability.
  • /packages/twenty-front/src/modules/ui/input/editor/components/CustomAddBlockItem.tsx: Added null check for Components context and introduced children prop for flexibility.

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@FelixMalfait FelixMalfait merged commit 43700ad into twentyhq:main Aug 7, 2024
5 of 11 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Thanks @ehconitin for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@ehconitin ehconitin deleted the ts-error-fixes branch August 7, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants