Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fileService getFileStream fallback after completed migration #6558

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Aug 6, 2024

To merge once the command has been executed.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the fallback mechanism in the getFileStream method of the FileService class, simplifying file retrieval from workspace-specific folders.

  • Removed error handling and fallback logic in packages/twenty-server/src/engine/core-modules/file/services/file.service.ts
  • Assumes all files have been migrated to workspace-specific folders
  • Critical to ensure file migration is complete before merging to prevent access issues
  • Simplifies getFileStream method by directly returning fileStorageService.read() result
  • Potential impact on file accessibility if migration is incomplete

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@thomtrp thomtrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let you merge once you ran the command

@Weiko Weiko merged commit 48d0a36 into main Aug 6, 2024
4 of 5 checks passed
@Weiko Weiko deleted the c--remove-file-stream-fallback branch August 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants