Force order in navigation panel for notes and tasks #6557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a new constant ORDERED_STANDARD_OBJECTS in the ObjectMetadataNavItems component to enforce a consistent order for standard objects in the navigation panel.
- Added
ORDERED_STANDARD_OBJECTSarray inpackages/twenty-front/src/modules/object-metadata/components/ObjectMetadataNavItems.tsx - Updated filtering logic to include 'task' and 'note' in the ordered list of standard objects
- Modified sorting algorithm to maintain consistent positioning of standard objects, including tasks and notes
- Ensures consistent order of navigation items, addressing the issue of tasks and notes changing positions
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
approved these changes
Aug 6, 2024
|
Not sure why we maintain this list, this should be handled differently imho. LGTM for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Tasks and Notes order sometimes change