Fix images in note rich text #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issues with images in note rich text by implementing secure access and improved handling of attachments and note bodies.
- Added
NoteQueryResultGetterHandlerinnote-query-result-getter.handler.tsto process note bodies and secure image access with signed tokens - Modified
AttachmentQueryResultGetterHandlerinattachment-query-result-getter.handler.tsto useAttachmentWorkspaceEntitytype and add signed payload tofullPath - Updated
QueryResultGettersFactoryinquery-result-getters.factory.tsto support note objects with the new handler - Improved security by ensuring only authorized users can access images in notes
- Enhanced rich text functionality, fixing image display issues as shown in the before/after screenshots
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| workspaceId: string, | ||
| ): Promise<NoteWorkspaceEntity> { | ||
| if (!note.id || !note.body) { | ||
| return note; |
There was a problem hiding this comment.
style: Wrap JSON.parse in a try-catch block to handle potential parsing errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Note: Not really happy with this implementation, ideally we should implement some generic logic for RICH_TEXT field type.
Note2: We should update the attachment table for new imported images, this was not done before but I'm creating a ticket for that.