Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message thread id from mcma and update scripts #6500

Merged

Conversation

bosiraphael
Copy link
Contributor

  • Remove messageThreadId from messageChannelMessageAssociation
  • Update thread merging
  • Update all queries which were dependent on this field
  • Update some raw queries by using twentyORM instead

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request removes the messageThreadId from messageChannelMessageAssociation and updates related scripts and queries.

  • Removed messageThreadId: Updated packages/twenty-server/src/database/typeorm-seeds/workspace/message-channel-message-associations.ts to remove messageThreadId and adjust seed data.
  • Updated Query Hooks: Modified packages/twenty-server/src/modules/messaging/common/query-hooks/message/message-find-many.pre-query.hook.ts and message-find-one.pre-query-hook.ts to use TwentyORMManager instead of MessageChannelMessageAssociationRepository.
  • Repository Changes: Significant updates to packages/twenty-server/src/modules/messaging/common/repositories/message-channel-message-association.repository.ts to remove methods dependent on messageThreadId.
  • Entity Updates: Removed messageThreadId relation from packages/twenty-server/src/modules/messaging/common/standard-objects/message-channel-message-association.workspace-entity.ts and message-thread.workspace-entity.ts.
  • Service Refactor: Deleted packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-thread.service.ts and updated other services to use TwentyORMManager.

13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosiraphael bosiraphael merged commit 018b822 into main Aug 6, 2024
6 checks passed
@bosiraphael bosiraphael deleted the remove-message-thread-id-from-mcma-and-update-scripts branch August 6, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants