-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove message thread id from mcma and update scripts #6500
Remove message thread id from mcma and update scripts #6500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The pull request removes the messageThreadId
from messageChannelMessageAssociation
and updates related scripts and queries.
- Removed
messageThreadId
: Updatedpackages/twenty-server/src/database/typeorm-seeds/workspace/message-channel-message-associations.ts
to removemessageThreadId
and adjust seed data. - Updated Query Hooks: Modified
packages/twenty-server/src/modules/messaging/common/query-hooks/message/message-find-many.pre-query.hook.ts
andmessage-find-one.pre-query-hook.ts
to useTwentyORMManager
instead ofMessageChannelMessageAssociationRepository
. - Repository Changes: Significant updates to
packages/twenty-server/src/modules/messaging/common/repositories/message-channel-message-association.repository.ts
to remove methods dependent onmessageThreadId
. - Entity Updates: Removed
messageThreadId
relation frompackages/twenty-server/src/modules/messaging/common/standard-objects/message-channel-message-association.workspace-entity.ts
andmessage-thread.workspace-entity.ts
. - Service Refactor: Deleted
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-thread.service.ts
and updated other services to useTwentyORMManager
.
13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
...ty-server/src/modules/messaging/message-import-manager/services/messaging-message.service.ts
Outdated
Show resolved
Hide resolved
...ty-server/src/modules/messaging/message-import-manager/services/messaging-message.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
messageThreadId
frommessageChannelMessageAssociation
twentyORM
instead