Add logs and fix timestamps in migrate domain command #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error logging and timestamp handling in the 0-23-migrate-domain-to-links.command.ts file to improve migration accuracy and debugging.
- File:
packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-migrate-domain-to-links.command.ts- Timestamps Exclusion: Removed
createdAtandupdatedAtfromdomainNameFieldduring migration. - Error Logging: Enhanced to include detailed error messages on migration failure.
- Potential Pitfalls: Risk of missing critical timestamps in future migrations and incomplete error handling scenarios.
- Timestamps Exclusion: Removed
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+135
to
+137
| createdAt: _createdAt, | ||
| updatedAt: _updatedAt, | ||
| ...domainNameFieldWithoutIdAndTimestamps |
There was a problem hiding this comment.
style: Ensure that excluding timestamps does not affect other parts of the migration process.
| @@ -207,6 +212,7 @@ export class MigrateDomainNameFromTextToLinksCommand extends CommandRunner { | |||
|
|
|||
| this.logger.log(`Migration of domainName done!`); | |||
| } catch (error) { | |||
| this.logger.log(`Error: ${error.message}`); | |||
There was a problem hiding this comment.
style: Consider adding more detailed error handling to cover different types of errors.
charlesBochet
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.