Build exceptions and handler #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-add-auth-exceptions
branch
2 times, most recently
from
92a984a to
ac9ae73
Compare
thomtrp
force-pushed
the
tt-add-auth-exceptions
branch
4 times, most recently
from
07976df to
a7f1dc3
Compare
thomtrp
force-pushed
the
tt-add-auth-exceptions
branch
from
a7f1dc3 to
ea83099
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces custom AuthExceptions and handlers to improve error management across the authentication services in the Twenty application.
- Adds new
AuthExceptionclass andAuthExceptionCodeenum inauth.exception.tsfor standardized error handling - Implements
AuthGraphqlApiExceptionFilterandAuthRestApiExceptionFilterto handle AuthExceptions in GraphQL and REST contexts - Replaces generic NestJS exceptions with custom AuthExceptions in various auth services and controllers
- Updates guards to use AuthExceptions with specific codes (e.g., FORBIDDEN_EXCEPTION) for better error clarity
- Modifies
AuthServiceandSignInUpServiceto use custom exceptions and improve input validation
19 file(s) reviewed, 13 comment(s)
Edit PR Review Bot Settings
...ages/twenty-server/src/engine/core-modules/auth/filters/auth-graphql-api-exception.filter.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/filters/auth-rest-api-exception.filter.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/guards/google-provider-enabled.guard.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/guards/microsoft-provider-enabled.guard.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/token.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/token.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/token.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/token.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/token.service.ts
Show resolved
Hide resolved
thomtrp
commented
Aug 6, 2024
| @@ -151,8 +137,6 @@ export class AuthResolver { | |||
| verifyInput.loginToken, | |||
| ); | |||
|
|
|||
| assert(email, 'Invalid token', ForbiddenException); | |||
There was a problem hiding this comment.
I moved the check to the function bellow
| if (!args.appToken) { | ||
| throw new BadRequestException('Refresh token is mendatory'); | ||
| } | ||
|
|
| assert(user.canImpersonate, 'User cannot impersonate', ForbiddenException); | ||
|
|
||
| return this.authService.impersonate(impersonateInput.userId); | ||
| return await this.authService.impersonate(impersonateInput.userId, user); |
| args.newPassword, | ||
| ); | ||
| const { id } = | ||
| await this.tokenService.validatePasswordResetToken(passwordResetToken); |
thomtrp
force-pushed
the
tt-add-auth-exceptions
branch
from
a7369af to
764e8e2
Compare
Weiko
reviewed
Aug 6, 2024
packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
Outdated
Show resolved
Hide resolved
Weiko
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding exceptions and handler for auth services.
Tested with: