Fix base graphql error message #6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
charlesBochet
approved these changes
Jul 30, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The update improves error reporting by displaying the actual error message instead of the error name in GraphQL responses.
- Modified
packages/twenty-server/src/engine/core-modules/graphql/utils/generate-graphql-error-from-error.util.tsto useerror.messageforBaseGraphQLError. - Ensures more informative error messages for debugging.
- Maintains conditional inclusion of stack trace and error message in development mode to avoid exposing sensitive information in production.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -5,7 +5,7 @@ import { | |||
|
|
|||
| export const generateGraphQLErrorFromError = (error: Error) => { | |||
| const graphqlError = new BaseGraphQLError( | |||
| error.name, | |||
| error.message, | |||
There was a problem hiding this comment.
style: Ensure error messages do not expose sensitive information in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display error message instead of name