Fix user query fragment #6450
Merged
Fix user query fragment #6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request addresses two main changes to improve flexibility and reduce complexity in the user query fragment.
packages/twenty-front/src/generated/graphql.tsx: ModifiedServerlessFunctiontype to make thedescriptionfield optional, allowing it to benull.packages/twenty-front/src/modules/users/graphql/fragments/userQueryFragment.ts: Simplified thedomainNamefield within thedefaultWorkspacefragment by removing its nested structure.
Ensure thorough testing to avoid null reference errors and update dependent queries and components accordingly.
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -695,7 +695,7 @@ export type Sentry = { | |||
| export type ServerlessFunction = { | |||
| __typename?: 'ServerlessFunction'; | |||
| createdAt: Scalars['DateTime']; | |||
| description: Scalars['String']; | |||
| description?: Maybe<Scalars['String']>; | |||
There was a problem hiding this comment.
style: Ensure all parts of the codebase that use ServerlessFunction.description handle null values correctly.
| primaryLinkUrl | ||
| primaryLinkLabel | ||
| } | ||
| domainName |
There was a problem hiding this comment.
style: Ensure all dependent queries and components are updated to handle the simplified domainName field.
ijreilly
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.