-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When exporting a kanban we should export the kanban's main field #6444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances the Kanban export functionality by including the Kanban's main field in the CSV export.
RecordIndexOptionsDropdownContent.tsx
: AddedviewType
prop to handle different view types (Kanban and Table) for export.useExportTableData.ts
: IntroducedviewType
parameter to include the Kanban's main field in the export.useTableData.ts
: Added logic to fetch and append the Kanban field to the export data when in Kanban view.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There are tests failing that were not failing when we sent the initial changes, what failed was only the coverage as we added a new feature. All tests passed before, the current failures are not related to PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
The latest changes focus on enhancing the Kanban export functionality by ensuring the main field used to build Kanban columns is included in the export data.
packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
: Addedhoverable
property toCheckbox
and updatedFieldContext.Provider
to userecordId
instead ofentityId
.packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/RecordBoardColumnHeader.tsx
: Introducedweight
prop toTag
component based oncolumnDefinition.type
.packages/twenty-front/src/modules/object-record/record-field/components/FieldDisplay.tsx
: Added support forRichTextFieldDisplay
andActorFieldDisplay
.packages/twenty-front/src/modules/object-record/record-field/hooks/useInitDraftValueV2.ts
: IncludedFIELD_NOT_OVERWRITTEN_AT_DRAFT
constant and replacedentityId
withrecordId
.packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts
: ReplacedentityId
withrecordId
for consistency.
298 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks
Log
|
This PR was created by GitStart to address the requirements from this ticket: TWNTY-6046.
This ticket was imported from: TWNTY-6046
Description
kanbanFieldMetadataNameState
, get the column data, and if there is data and the use is on the Kanban view we add the data to the resultRefs
#6046
Demo
https://jam.dev/c/96f16211-40e4-4b49-a6f5-88f0692fb47a
Fixes #6046