Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise coverage #6441

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Raise coverage #6441

merged 1 commit into from
Jul 29, 2024

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Jul 29, 2024

Adding a few tests and remove a few unused files to raise code coverage a bit

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request focuses on improving code organization, correcting import paths, and enhancing test coverage.

  • CalendarEventParticipantsResponseStatusField.tsx: Reordered imports and corrected import path for isRightDrawerAnimationCompletedState.
  • ActivityEditorFields.tsx: Updated import path for isRightDrawerAnimationCompletedState.
  • ActivityTargetInlineCellEditMode.tsx: Removed getActivityTargetObjectFieldName import and replaced with direct reference to record.objectMetadataItem.nameSingular.
  • getActivityTargetObjectFieldName.ts: Deleted as its functionality was replaced.
  • RightDrawer.tsx: Reordered imports and corrected import path for isRightDrawerAnimationCompletedState.
  • isRightDrawerAnimationCompletedState.ts: Renamed and updated to use createState from twenty-ui.
  • isValidUuid.test.ts: Added new test file to validate isValidUuid utility function.

7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet merged commit 0a21a16 into main Jul 29, 2024
13 checks passed
@charlesBochet charlesBochet deleted the raise-coverage branch July 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant