6431 create new field activationStatus inside workspace table #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Introduced a new activationStatus field to the workspace table, along with necessary migrations and logic updates to ensure consistent status tracking.
- Added
WorkspaceActivationStatusenum and updatedWorkspacetype inpackages/twenty-front/src/generated/graphql.tsx. - Updated workspace activation logic in
packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts. - Added migration
1722256203539-addActivationStatus.tsinpackages/twenty-server/src/database/typeorm/core/migrations/. - Integrated
activationStatusupdates inpackages/twenty-server/src/engine/core-modules/billing/billing.workspace-service.ts. - Created
SetWorkspaceActivationStatusCommandinpackages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-set-workspace-activation-status.command.ts.
16 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+53
to
+60
| let activeSubscriptionWorkspaceIds: string[] = []; | ||
|
|
||
| if (options.workspaceId) { | ||
| activeSubscriptionWorkspaceIds = [options.workspaceId]; | ||
| } else { | ||
| activeSubscriptionWorkspaceIds = | ||
| await this.billingService.getActiveSubscriptionWorkspaceIds(); | ||
| } |
There was a problem hiding this comment.
Logic: Consider adding error handling for the getActiveSubscriptionWorkspaceIds method to handle potential failures gracefully.
bosiraphael
deleted the
6431-create-new-field-status-inside-workspace-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6431
activationStatusactivationStatuson workspace activation and on stripe subscriptionStatus change