Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeline activity deleted field #6433

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Jul 29, 2024

Fixes #6362

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request introduces a filtering mechanism to remove invalid events from the timeline activities, ensuring only valid events are processed and displayed.

  • EventList.tsx: Added filtering step using filterOutInvalidEvents to remove invalid events before grouping by month.
  • filterOutInvalidEvents.ts: Introduced filterOutInvalidEvents utility function to filter out invalid events based on mainObjectMetadataItem.
  • filterOutInvalidEvents.test.ts: Added unit tests for filterOutInvalidEvents covering various scenarios to ensure robustness.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Weiko Weiko merged commit 4389e81 into main Jul 29, 2024
7 of 12 checks passed
@Weiko Weiko deleted the c--fix-timeline-activity-deleted-field branch July 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline activity crashes when attempting to report updates on deleted field
3 participants