Filter out by error code + invert filtering #6432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The changes in should-capture-exception.util.ts focus on renaming an array and inverting the logic for filtering GraphQL errors.
- Renamed
graphQLErrorCodesToFiltertographQLErrorCodesToFilterOut. - Inverted logic in
shouldCaptureExceptionto returnfalsefor filtered error codes. - Potential issue with
@ts-expect-errorcomment, which may hide type issues.
These changes simplify the logic but ensure to address the type error comment for robustness.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
approved these changes
Jul 29, 2024
charlesBochet
approved these changes
Jul 29, 2024
charlesBochet
force-pushed
the
tt-filter-out-graphql-user-input-errors
branch
from
87fe332
to
0753853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
Instance of not working well.